diff options
| author | David Howells <[email protected]> | 2025-06-25 13:15:04 +0000 |
|---|---|---|
| committer | Steve French <[email protected]> | 2025-06-26 16:13:13 +0000 |
| commit | 43e7e284fc77b710d899569360ea46fa3374ae22 (patch) | |
| tree | 17bdaa5b8fd5d5fc2da335a4c824d32d5538a1b3 /lib/crypto/mpi/mpi-pow.c | |
| parent | smb: client: fix potential deadlock when reconnecting channels (diff) | |
| download | kernel-43e7e284fc77b710d899569360ea46fa3374ae22.tar.gz kernel-43e7e284fc77b710d899569360ea46fa3374ae22.zip | |
cifs: Fix the smbd_response slab to allow usercopy
The handling of received data in the smbdirect client code involves using
copy_to_iter() to copy data from the smbd_reponse struct's packet trailer
to a folioq buffer provided by netfslib that encapsulates a chunk of
pagecache.
If, however, CONFIG_HARDENED_USERCOPY=y, this will result in the checks
then performed in copy_to_iter() oopsing with something like the following:
CIFS: Attempting to mount //172.31.9.1/test
CIFS: VFS: RDMA transport established
usercopy: Kernel memory exposure attempt detected from SLUB object 'smbd_response_0000000091e24ea1' (offset 81, size 63)!
------------[ cut here ]------------
kernel BUG at mm/usercopy.c:102!
...
RIP: 0010:usercopy_abort+0x6c/0x80
...
Call Trace:
<TASK>
__check_heap_object+0xe3/0x120
__check_object_size+0x4dc/0x6d0
smbd_recv+0x77f/0xfe0 [cifs]
cifs_readv_from_socket+0x276/0x8f0 [cifs]
cifs_read_from_socket+0xcd/0x120 [cifs]
cifs_demultiplex_thread+0x7e9/0x2d50 [cifs]
kthread+0x396/0x830
ret_from_fork+0x2b8/0x3b0
ret_from_fork_asm+0x1a/0x30
The problem is that the smbd_response slab's packet field isn't marked as
being permitted for usercopy.
Fix this by passing parameters to kmem_slab_create() to indicate that
copy_to_iter() is permitted from the packet region of the smbd_response
slab objects, less the header space.
Fixes: ee4cdf7ba857 ("netfs: Speed up buffered reading")
Reported-by: Stefan Metzmacher <[email protected]>
Link: https://lore.kernel.org/r/[email protected]/
Signed-off-by: David Howells <[email protected]>
Reviewed-by: Stefan Metzmacher <[email protected]>
Tested-by: Stefan Metzmacher <[email protected]>
cc: Paulo Alcantara <[email protected]>
cc: [email protected]
cc: [email protected]
cc: [email protected]
Signed-off-by: Steve French <[email protected]>
Diffstat (limited to 'lib/crypto/mpi/mpi-pow.c')
0 files changed, 0 insertions, 0 deletions
