aboutsummaryrefslogtreecommitdiffstats
path: root/lib/crypto/mpi/mpi-cmp.c
diff options
context:
space:
mode:
authorDan Williams <[email protected]>2025-06-12 19:20:43 +0000
committerDave Jiang <[email protected]>2025-06-13 16:02:04 +0000
commit3c70ec71abdaf4e4fa48cd8fdfbbd864d78235a8 (patch)
treed113f92df17a9168d682f32f34bf8b95ac2b559f /lib/crypto/mpi/mpi-cmp.c
parentcxl/edac: Fix potential memory leak issues (diff)
downloadkernel-3c70ec71abdaf4e4fa48cd8fdfbbd864d78235a8.tar.gz
kernel-3c70ec71abdaf4e4fa48cd8fdfbbd864d78235a8.zip
cxl/ras: Fix CPER handler device confusion
By inspection, cxl_cper_handle_prot_err() is making a series of fragile assumptions that can lead to crashes: 1/ It assumes that endpoints identified in the record are a CXL-type-3 device, nothing guarantees that. 2/ It assumes that the device is bound to the cxl_pci driver, nothing guarantees that. 3/ Minor, it holds the device lock over the switch-port tracing for no reason as the trace is 100% generated from data in the record. Correct those by checking that the PCIe endpoint parents a cxl_memdev before assuming the format of the driver data, and move the lock to where it is required. Consequently this also makes the implementation ready for CXL accelerators that are not bound to cxl_pci. Fixes: 36f257e3b0ba ("acpi/ghes, cxl/pci: Process CXL CPER Protocol Errors") Cc: Terry Bowman <[email protected]> Cc: Li Ming <[email protected]> Cc: Alison Schofield <[email protected]> Cc: Ira Weiny <[email protected]> Cc: Tony Luck <[email protected]> Reviewed-by: Smita Koralahalli <[email protected]> Reviewed-by: Dave Jiang <[email protected]> Signed-off-by: Dan Williams <[email protected]> Reviewed-by: Jonathan Cameron <[email protected]> Reviewed-by: Li Ming <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Dave Jiang <[email protected]>
Diffstat (limited to 'lib/crypto/mpi/mpi-cmp.c')
0 files changed, 0 insertions, 0 deletions