diff options
| author | NeilBrown <[email protected]> | 2025-06-08 23:35:09 +0000 |
|---|---|---|
| committer | Steve French <[email protected]> | 2025-07-21 00:17:14 +0000 |
| commit | d5fc1400a34b4ea5e8f2ce296ea12bf8c8421694 (patch) | |
| tree | 89ba55d2f9a24caff70d9b914b972a1f83527194 /lib/crypto/mpi/mpi-add.c | |
| parent | smb/server: simplify ksmbd_vfs_kern_path_locked() (diff) | |
| download | kernel-d5fc1400a34b4ea5e8f2ce296ea12bf8c8421694.tar.gz kernel-d5fc1400a34b4ea5e8f2ce296ea12bf8c8421694.zip | |
smb/server: avoid deadlock when linking with ReplaceIfExists
If smb2_create_link() is called with ReplaceIfExists set and the name
does exist then a deadlock will happen.
ksmbd_vfs_kern_path_locked() will return with success and the parent
directory will be locked. ksmbd_vfs_remove_file() will then remove the
file. ksmbd_vfs_link() will then be called while the parent is still
locked. It will try to lock the same parent and will deadlock.
This patch moves the ksmbd_vfs_kern_path_unlock() call to *before*
ksmbd_vfs_link() and then simplifies the code, removing the file_present
flag variable.
Signed-off-by: NeilBrown <[email protected]>
Acked-by: Namjae Jeon <[email protected]>
Signed-off-by: Steve French <[email protected]>
Diffstat (limited to 'lib/crypto/mpi/mpi-add.c')
0 files changed, 0 insertions, 0 deletions