diff options
| author | Pavel Begunkov <[email protected]> | 2022-06-17 08:48:00 +0000 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2022-07-25 00:39:14 +0000 |
| commit | d245bca6375bccfd589a6a7d5007df28575bb626 (patch) | |
| tree | ce0fbcda110609810940ebd21bdebeb2d942513f /io_uring/poll.c | |
| parent | io_uring: kbuf: add comments for some tricky code (diff) | |
| download | kernel-d245bca6375bccfd589a6a7d5007df28575bb626.tar.gz kernel-d245bca6375bccfd589a6a7d5007df28575bb626.zip | |
io_uring: don't expose io_fill_cqe_aux()
Deduplicate some code and add a helper for filling an aux CQE, locking
and notification.
Signed-off-by: Pavel Begunkov <[email protected]>
Link: https://lore.kernel.org/r/b7c6557c8f9dc5c4cfb01292116c682a0ff61081.1655455613.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'io_uring/poll.c')
| -rw-r--r-- | io_uring/poll.c | 22 |
1 files changed, 7 insertions, 15 deletions
diff --git a/io_uring/poll.c b/io_uring/poll.c index 9ae2982aef7c..e0c181fe6264 100644 --- a/io_uring/poll.c +++ b/io_uring/poll.c @@ -214,24 +214,16 @@ static int io_poll_check_events(struct io_kiocb *req, bool *locked) if (!(req->flags & REQ_F_APOLL_MULTISHOT)) { __poll_t mask = mangle_poll(req->cqe.res & req->apoll_events); - bool filled; - spin_lock(&ctx->completion_lock); - filled = io_fill_cqe_aux(ctx, req->cqe.user_data, - mask, IORING_CQE_F_MORE); - io_commit_cqring(ctx); - spin_unlock(&ctx->completion_lock); - if (filled) { - io_cqring_ev_posted(ctx); - continue; - } - return -ECANCELED; + if (!io_post_aux_cqe(ctx, req->cqe.user_data, + mask, IORING_CQE_F_MORE)) + return -ECANCELED; + } else { + ret = io_poll_issue(req, locked); + if (ret) + return ret; } - ret = io_poll_issue(req, locked); - if (ret) - return ret; - /* * Release all references, retry if someone tried to restart * task_work while we were executing it. |