diff options
| author | Pavel Begunkov <[email protected]> | 2025-07-16 16:20:17 +0000 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2025-07-16 16:28:28 +0000 |
| commit | c7cafd5b81cc07fb402e3068d134c21e60ea688c (patch) | |
| tree | eae01611b66897e70652f8e8a53d280df1c3a4c9 /io_uring/poll.c | |
| parent | io_uring/zcrx: disallow user selected dmabuf offset and size (diff) | |
| download | kernel-c7cafd5b81cc07fb402e3068d134c21e60ea688c.tar.gz kernel-c7cafd5b81cc07fb402e3068d134c21e60ea688c.zip | |
io_uring/poll: fix POLLERR handling
8c8492ca64e7 ("io_uring/net: don't retry connect operation on EPOLLERR")
is a little dirty hack that
1) wrongfully assumes that POLLERR equals to a failed request, which
breaks all POLLERR users, e.g. all error queue recv interfaces.
2) deviates the connection request behaviour from connect(2), and
3) racy and solved at a wrong level.
Nothing can be done with 2) now, and 3) is beyond the scope of the
patch. At least solve 1) by moving the hack out of generic poll handling
into io_connect().
Cc: [email protected]
Fixes: 8c8492ca64e79 ("io_uring/net: don't retry connect operation on EPOLLERR")
Signed-off-by: Pavel Begunkov <[email protected]>
Link: https://lore.kernel.org/r/3dc89036388d602ebd84c28e5042e457bdfc952b.1752682444.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'io_uring/poll.c')
| -rw-r--r-- | io_uring/poll.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/io_uring/poll.c b/io_uring/poll.c index 0526062e2f81..20e9b46a4adf 100644 --- a/io_uring/poll.c +++ b/io_uring/poll.c @@ -273,8 +273,6 @@ static int io_poll_check_events(struct io_kiocb *req, io_tw_token_t tw) return IOU_POLL_REISSUE; } } - if (unlikely(req->cqe.res & EPOLLERR)) - req_set_fail(req); if (req->apoll_events & EPOLLONESHOT) return IOU_POLL_DONE; |