diff options
| author | Qingyue Zhang <[email protected]> | 2025-08-27 11:43:39 +0000 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2025-08-27 14:39:44 +0000 |
| commit | c64eff368ac676e8540344d27a3de47e0ad90d21 (patch) | |
| tree | 089c55d83a80667ce71b96721acfe9a0d5eedd44 /io_uring/kbuf.c | |
| parent | io_uring: clear ->async_data as part of normal init (diff) | |
| download | kernel-c64eff368ac676e8540344d27a3de47e0ad90d21.tar.gz kernel-c64eff368ac676e8540344d27a3de47e0ad90d21.zip | |
io_uring/kbuf: fix signedness in this_len calculation
When importing and using buffers, buf->len is considered unsigned.
However, buf->len is converted to signed int when committing. This can
lead to unexpected behavior if the buffer is large enough to be
interpreted as a negative value. Make min_t calculation unsigned.
Fixes: ae98dbf43d75 ("io_uring/kbuf: add support for incremental buffer consumption")
Co-developed-by: Suoxing Zhang <[email protected]>
Signed-off-by: Suoxing Zhang <[email protected]>
Signed-off-by: Qingyue Zhang <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'io_uring/kbuf.c')
| -rw-r--r-- | io_uring/kbuf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/io_uring/kbuf.c b/io_uring/kbuf.c index f2d2cc319faa..81a13338dfab 100644 --- a/io_uring/kbuf.c +++ b/io_uring/kbuf.c @@ -39,7 +39,7 @@ static bool io_kbuf_inc_commit(struct io_buffer_list *bl, int len) u32 this_len; buf = io_ring_head_to_buf(bl->buf_ring, bl->head, bl->mask); - this_len = min_t(int, len, buf->len); + this_len = min_t(u32, len, buf->len); buf->len -= this_len; if (buf->len) { buf->addr += this_len; |