diff options
| author | Uladzislau Rezki (Sony) <[email protected]> | 2025-08-31 12:10:58 +0000 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2025-09-09 06:45:11 +0000 |
| commit | 79357cd06d41d0f5a11b17d7c86176e395d10ef2 (patch) | |
| tree | d9918f16f97e3c802154863d03aa93f8cfd8f55f /fs/xfs/xfs_zone_alloc.c | |
| parent | ocfs2: fix recursive semaphore deadlock in fiemap call (diff) | |
| download | kernel-79357cd06d41d0f5a11b17d7c86176e395d10ef2.tar.gz kernel-79357cd06d41d0f5a11b17d7c86176e395d10ef2.zip | |
mm/vmalloc, mm/kasan: respect gfp mask in kasan_populate_vmalloc()
kasan_populate_vmalloc() and its helpers ignore the caller's gfp_mask and
always allocate memory using the hardcoded GFP_KERNEL flag. This makes
them inconsistent with vmalloc(), which was recently extended to support
GFP_NOFS and GFP_NOIO allocations.
Page table allocations performed during shadow population also ignore the
external gfp_mask. To preserve the intended semantics of GFP_NOFS and
GFP_NOIO, wrap the apply_to_page_range() calls into the appropriate
memalloc scope.
xfs calls vmalloc with GFP_NOFS, so this bug could lead to deadlock.
There was a report here
https://lkml.kernel.org/r/[email protected]
This patch:
- Extends kasan_populate_vmalloc() and helpers to take gfp_mask;
- Passes gfp_mask down to alloc_pages_bulk() and __get_free_page();
- Enforces GFP_NOFS/NOIO semantics with memalloc_*_save()/restore()
around apply_to_page_range();
- Updates vmalloc.c and percpu allocator call sites accordingly.
Link: https://lkml.kernel.org/r/[email protected]
Fixes: 451769ebb7e7 ("mm/vmalloc: alloc GFP_NO{FS,IO} for vmalloc")
Signed-off-by: Uladzislau Rezki (Sony) <[email protected]>
Reported-by: [email protected]
Reviewed-by: Andrey Ryabinin <[email protected]>
Cc: Baoquan He <[email protected]>
Cc: Michal Hocko <[email protected]>
Cc: Alexander Potapenko <[email protected]>
Cc: Andrey Konovalov <[email protected]>
Cc: Dmitry Vyukov <[email protected]>
Cc: Vincenzo Frascino <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'fs/xfs/xfs_zone_alloc.c')
0 files changed, 0 insertions, 0 deletions
