diff options
| author | Neil Brown <[email protected]> | 2010-12-02 00:14:30 +0000 |
|---|---|---|
| committer | J. Bruce Fields <[email protected]> | 2010-12-08 16:44:04 +0000 |
| commit | c1ac3ffcd0bc7e9617f62be8c7043d53ab84deac (patch) | |
| tree | 174842d423f84a5a80cb0caed70815d174b516f9 /fs/ubifs/commit.c | |
| parent | sunrpc: prevent use-after-free on clearing XPT_BUSY (diff) | |
| download | kernel-c1ac3ffcd0bc7e9617f62be8c7043d53ab84deac.tar.gz kernel-c1ac3ffcd0bc7e9617f62be8c7043d53ab84deac.zip | |
nfsd: Fix possible BUG_ON firing in set_change_info
If vfs_getattr in fill_post_wcc returns an error, we don't
set fh_post_change.
For NFSv4, this can result in set_change_info triggering a BUG_ON.
i.e. fh_post_saved being zero isn't really a bug.
So:
- instead of BUGging when fh_post_saved is zero, just clear ->atomic.
- if vfs_getattr fails in fill_post_wcc, take a copy of i_ctime anyway.
This will be used i seg_change_info, but not overly trusted.
- While we are there, remove the pointless 'if' statements in set_change_info.
There is no harm setting all the values.
Signed-off-by: NeilBrown <[email protected]>
Cc: [email protected]
Signed-off-by: J. Bruce Fields <[email protected]>
Diffstat (limited to 'fs/ubifs/commit.c')
0 files changed, 0 insertions, 0 deletions