diff options
| author | Kees Cook <[email protected]> | 2020-06-03 20:28:45 +0000 |
|---|---|---|
| committer | Kees Cook <[email protected]> | 2020-07-16 19:32:25 +0000 |
| commit | 805cdb8bc6da87818fe3b27798a5031b54ed7b20 (patch) | |
| tree | 768b06b3269d583447455710d92b9e00e2427506 /fs/ubifs/commit.c | |
| parent | x86/mm/numa: Remove uninitialized_var() usage (diff) | |
| download | kernel-805cdb8bc6da87818fe3b27798a5031b54ed7b20.tar.gz kernel-805cdb8bc6da87818fe3b27798a5031b54ed7b20.zip | |
drbd: Remove uninitialized_var() usage
Using uninitialized_var() is dangerous as it papers over real bugs[1]
(or can in the future), and suppresses unrelated compiler warnings (e.g.
"unused variable"). If the compiler thinks it is uninitialized, either
simply initialize the variable or make compiler changes. As a precursor
to removing[2] this[3] macro[4], just initialize this variable to NULL.
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/
[3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/
[4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/
Fixes: a29728463b25 ("drbd: Backport the "events2" command")
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Kees Cook <[email protected]>
Diffstat (limited to 'fs/ubifs/commit.c')
0 files changed, 0 insertions, 0 deletions