diff options
| author | Alexey Dobriyan <[email protected]> | 2018-04-10 23:32:20 +0000 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2018-04-11 17:28:34 +0000 |
| commit | 4f1134370a29a5f2d0f4b4be4c5e2fddd38f0f9d (patch) | |
| tree | 0fcae1f568cf1c2870f615e214f3e92a77afcd30 /fs/proc/proc_net.c | |
| parent | proc: selftests: shotgun testing of read/readdir/readlink/write (diff) | |
| download | kernel-4f1134370a29a5f2d0f4b4be4c5e2fddd38f0f9d.tar.gz kernel-4f1134370a29a5f2d0f4b4be4c5e2fddd38f0f9d.zip | |
proc: use slower rb_first()
In a typical for /proc "open+read+close" usecase, dentry is looked up
successfully on open only to be killed in dput() on close. In fact
dentries which aren't /proc/*/... and /proc/sys/* were almost NEVER
CACHED. Simple printk in proc_lookup_de() shows that.
Now that ->delete hook intelligently picks which dentries should live in
dcache and which should not, rbtree caching is not necessary as dcache
does it job, at last!
As a side effect, struct proc_dir_entry shrinks by one pointer which can
go into inline name.
Link: http://lkml.kernel.org/r/20180314231032.GA15854@avx2
Signed-off-by: Alexey Dobriyan <[email protected]>
Acked-by: Davidlohr Bueso <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Al Viro <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'fs/proc/proc_net.c')
| -rw-r--r-- | fs/proc/proc_net.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c index e5fe3d400737..1763f370489d 100644 --- a/fs/proc/proc_net.c +++ b/fs/proc/proc_net.c @@ -196,7 +196,7 @@ static __net_init int proc_net_ns_init(struct net *net) if (!netd) goto out; - netd->subdir = RB_ROOT_CACHED; + netd->subdir = RB_ROOT; netd->data = net; netd->nlink = 2; netd->namelen = 3; |