diff options
| author | wangzijie <[email protected]> | 2025-06-07 02:13:53 +0000 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2025-07-10 05:42:01 +0000 |
| commit | ff7ec8dc1b646296f8d94c39339e8d3833d16c05 (patch) | |
| tree | 3f0760e7cfaf35420dd9cbfea44c2f2299e6b4d0 /fs/proc/internal.h | |
| parent | mm: use per_vma lock for MADV_DONTNEED (diff) | |
| download | kernel-ff7ec8dc1b646296f8d94c39339e8d3833d16c05.tar.gz kernel-ff7ec8dc1b646296f8d94c39339e8d3833d16c05.zip | |
proc: use the same treatment to check proc_lseek as ones for proc_read_iter et.al
Check pde->proc_ops->proc_lseek directly may cause UAF in rmmod scenario.
It's a gap in proc_reg_open() after commit 654b33ada4ab("proc: fix UAF in
proc_get_inode()"). Followed by AI Viro's suggestion, fix it in same
manner.
Link: https://lkml.kernel.org/r/[email protected]
Fixes: 3f61631d47f1 ("take care to handle NULL ->proc_lseek()")
Signed-off-by: wangzijie <[email protected]>
Reviewed-by: Alexey Dobriyan <[email protected]>
Cc: Alexei Starovoitov <[email protected]>
Cc: Al Viro <[email protected]>
Cc: "Edgecombe, Rick P" <[email protected]>
Cc: Kirill A. Shuemov <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'fs/proc/internal.h')
| -rw-r--r-- | fs/proc/internal.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/proc/internal.h b/fs/proc/internal.h index 96122e91c645..3d48ffe72583 100644 --- a/fs/proc/internal.h +++ b/fs/proc/internal.h @@ -99,6 +99,11 @@ static inline bool pde_has_proc_compat_ioctl(const struct proc_dir_entry *pde) #endif } +static inline bool pde_has_proc_lseek(const struct proc_dir_entry *pde) +{ + return pde->flags & PROC_ENTRY_proc_lseek; +} + extern struct kmem_cache *proc_dir_entry_cache; void pde_free(struct proc_dir_entry *pde); |