diff options
| author | Johan Hovold <[email protected]> | 2020-09-09 14:31:00 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2020-09-16 11:22:10 +0000 |
| commit | fe88c6489264eaea23570dfdf03e1d3f5f47f423 (patch) | |
| tree | 3a718fd52c2788836eda9320438748bfa1437516 /fs/proc/array.c | |
| parent | Linux 5.9-rc3 (diff) | |
| download | kernel-fe88c6489264eaea23570dfdf03e1d3f5f47f423.tar.gz kernel-fe88c6489264eaea23570dfdf03e1d3f5f47f423.zip | |
serial: core: fix port-lock initialisation
Commit f743061a85f5 ("serial: core: Initialise spin lock before use in
uart_configure_port()") tried to work around a breakage introduced by
commit a3cb39d258ef ("serial: core: Allow detach and attach serial
device for console") by adding a second initialisation of the port lock
when registering the port.
As reported by the build robots [1], this doesn't really solve the
regression introduced by the console-detach changes and also adds a
second redundant initialisation of the lock for normal ports.
Start cleaning up this mess by removing the redundant initialisation and
making sure that the port lock is again initialised once-only for ports
that aren't already in use as a console.
[1] https://lore.kernel.org/r/20200802054852.GR23458@shao2-debian
Fixes: f743061a85f5 ("serial: core: Initialise spin lock before use in uart_configure_port()")
Fixes: a3cb39d258ef ("serial: core: Allow detach and attach serial device for console")
Cc: stable <[email protected]> # 5.7
Signed-off-by: Johan Hovold <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'fs/proc/array.c')
0 files changed, 0 insertions, 0 deletions
