diff options
| author | Christian Brauner <[email protected]> | 2021-08-26 01:07:05 +0000 |
|---|---|---|
| committer | Steve French <[email protected]> | 2021-09-04 04:29:45 +0000 |
| commit | db7fb6fe3d7a8eb05f2b74c6252771c9362f3b74 (patch) | |
| tree | 1fd4ac4ed92908c911947c4937ef96876da31ff3 /fs/proc/array.c | |
| parent | ksmbd: ensure error is surfaced in set_file_basic_info() (diff) | |
| download | kernel-db7fb6fe3d7a8eb05f2b74c6252771c9362f3b74.tar.gz kernel-db7fb6fe3d7a8eb05f2b74c6252771c9362f3b74.zip | |
ksmbd: remove setattr preparations in set_file_basic_info()
Permission checking and copying over ownership information is the task
of the underlying filesystem not ksmbd. The order is also wrong here.
This modifies the inode before notify_change(). If notify_change() fails
this will have changed ownership nonetheless. All of this is unnecessary
though since the underlying filesystem's ->setattr handler will do all
this (if required) by itself.
Cc: Steve French <[email protected]>
Cc: Christoph Hellwig <[email protected]>
Cc: Namjae Jeon <[email protected]>
Cc: Hyunchul Lee <[email protected]>
Cc: Sergey Senozhatsky <[email protected]>
Cc: [email protected]
Signed-off-by: Christian Brauner <[email protected]>
Signed-off-by: Namjae Jeon <[email protected]>
Signed-off-by: Steve French <[email protected]>
Diffstat (limited to 'fs/proc/array.c')
0 files changed, 0 insertions, 0 deletions