diff options
| author | Eric W. Biederman <[email protected]> | 2021-12-23 16:05:19 +0000 |
|---|---|---|
| committer | Eric W. Biederman <[email protected]> | 2022-01-08 18:43:57 +0000 |
| commit | 270b6541e603a7fae0cad7af3dc3bca6adb343f3 (patch) | |
| tree | f9593f5328c3f636a692d88b520fe2a978b09ae2 /fs/proc/array.c | |
| parent | exit: Remove profile_handoff_task (diff) | |
| download | kernel-270b6541e603a7fae0cad7af3dc3bca6adb343f3.tar.gz kernel-270b6541e603a7fae0cad7af3dc3bca6adb343f3.zip | |
exit: Coredumps reach do_group_exit
The comment about coredumps not reaching do_group_exit and the
corresponding BUG_ON are bogus.
What happens and has happened for years is that get_signal calls
do_coredump (which sets SIGNAL_GROUP_EXIT and group_exit_code) and
then do_group_exit passing the signal number. Then do_group_exit
ignores the exit_code it is passed and uses signal->group_exit_code
from the coredump.
The comment and BUG_ON were correct when they were added during the
2.5 development cycle, but became obsolete and incorrect when
get_signal was changed to fall through to do_group_exit after
do_coredump in 2.6.10-rc2.
So remove the stale comment and BUG_ON
Fixes: 63bd6144f191 ("[PATCH] Invalid BUG_ONs in signal.c")
History-Tree: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git
Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: "Eric W. Biederman" <[email protected]>
Diffstat (limited to 'fs/proc/array.c')
0 files changed, 0 insertions, 0 deletions