diff options
| author | Heikki Krogerus <[email protected]> | 2020-09-16 09:00:33 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2020-09-16 10:34:03 +0000 |
| commit | 130a96d698d7bee9f339832d1e47ab26aad8dbf1 (patch) | |
| tree | 893f3827ec4a0fdbffb7126251e4e3b0b6fcf7bb /fs/proc/array.c | |
| parent | Merge tag 'thunderbolt-for-v5.9-rc6' of git://git.kernel.org/pub/scm/linux/ke... (diff) | |
| download | kernel-130a96d698d7bee9f339832d1e47ab26aad8dbf1.tar.gz kernel-130a96d698d7bee9f339832d1e47ab26aad8dbf1.zip | |
usb: typec: ucsi: acpi: Increase command completion timeout value
UCSI specification quite clearly states that if a command
can't be completed in 10ms, the firmware must notify
about BUSY condition. Unfortunately almost none of the
platforms (the firmware on them) generate the BUSY
notification even if a command can't be completed in time.
The driver already considered that, and used a timeout
value of 5 seconds, but processing especially the alternate
mode discovery commands takes often considerable amount of
time from the firmware, much more than the 5 seconds. That
happens especially after bootup when devices are already
connected to the USB Type-C connector. For now on those
platforms the alternate mode discovery has simply failed
because of the timeout.
To improve the situation, increasing the timeout value for
the command completion to 1 minute. That should give enough
time for even the slowest firmware to process the commands.
Fixes: f56de278e8ec ("usb: typec: ucsi: acpi: Move to the new API")
Cc: [email protected]
Signed-off-by: Heikki Krogerus <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'fs/proc/array.c')
0 files changed, 0 insertions, 0 deletions