diff options
| author | Jan Kara <[email protected]> | 2022-11-21 13:09:29 +0000 |
|---|---|---|
| committer | Theodore Ts'o <[email protected]> | 2022-12-09 02:49:25 +0000 |
| commit | b40ebaf63851b3a401b0dc9263843538f64f5ce6 (patch) | |
| tree | 8c33b3f959c22976b465ef20881a51eecd51338e /fs/jbd2/commit.c | |
| parent | fs: ext4: initialize fsdata in pagecache_write() (diff) | |
| download | kernel-b40ebaf63851b3a401b0dc9263843538f64f5ce6.tar.gz kernel-b40ebaf63851b3a401b0dc9263843538f64f5ce6.zip | |
ext4: avoid BUG_ON when creating xattrs
Commit fb0a387dcdcd ("ext4: limit block allocations for indirect-block
files to < 2^32") added code to try to allocate xattr block with 32-bit
block number for indirect block based files on the grounds that these
files cannot use larger block numbers. It also added BUG_ON when
allocated block could not fit into 32 bits. This is however bogus
reasoning because xattr block is stored in inode->i_file_acl and
inode->i_file_acl_hi and as such even indirect block based files can
happily use full 48 bits for xattr block number. The proper handling
seems to be there basically since 64-bit block number support was added.
So remove the bogus limitation and BUG_ON.
Cc: Eric Sandeen <[email protected]>
Fixes: fb0a387dcdcd ("ext4: limit block allocations for indirect-block files to < 2^32")
Signed-off-by: Jan Kara <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Theodore Ts'o <[email protected]>
Cc: [email protected]
Diffstat (limited to 'fs/jbd2/commit.c')
0 files changed, 0 insertions, 0 deletions