diff options
| author | Jeff Moyer <[email protected]> | 2012-03-05 15:19:52 +0000 |
|---|---|---|
| committer | Theodore Ts'o <[email protected]> | 2012-03-05 15:19:52 +0000 |
| commit | 93ef8541d5c3ad1a73057ff358a49d0ee7146d6f (patch) | |
| tree | 70c2a7cac370084edac29ee0156f52d488ee32ab /fs/jbd2/commit.c | |
| parent | ext4: try to deprecate noacl and noxattr_user mount options (diff) | |
| download | kernel-93ef8541d5c3ad1a73057ff358a49d0ee7146d6f.tar.gz kernel-93ef8541d5c3ad1a73057ff358a49d0ee7146d6f.zip | |
ext4: clean up the flags passed to __blockdev_direct_IO
For extent-based files, you can perform DIO to holes, as mentioned in
the comments in ext4_ext_direct_IO. However, that function passes
DIO_SKIP_HOLES to __blockdev_direct_IO, which is *really* confusing to
the uninitiated reader. The key, here, is that the get_block function
passed in, ext4_get_block_write, completely ignores the create flag
that is passed to it (the create flag is passed in from the direct I/O
code, which uses the DIO_SKIP_HOLES flag to determine whether or not
it should be cleared).
This is a long-winded way of saying that the DIO_SKIP_HOLES flag is
ultimately ignored. So let's remove it.
Signed-off-by: Jeff Moyer <[email protected]>
Signed-off-by: "Theodore Ts'o" <[email protected]>
Diffstat (limited to 'fs/jbd2/commit.c')
0 files changed, 0 insertions, 0 deletions