diff options
| author | Jinliang Zheng <[email protected]> | 2024-09-19 08:25:39 +0000 |
|---|---|---|
| committer | Theodore Ts'o <[email protected]> | 2024-11-13 04:54:14 +0000 |
| commit | 25f51ea8ac8144af2fefb743c3439547610368ff (patch) | |
| tree | 572ff8922f99044e71639799628bb1b54fb292ac /fs/jbd2/commit.c | |
| parent | ext4: pass write-hint for buffered IO (diff) | |
| download | kernel-25f51ea8ac8144af2fefb743c3439547610368ff.tar.gz kernel-25f51ea8ac8144af2fefb743c3439547610368ff.zip | |
ext4: disambiguate the return value of ext4_dio_write_end_io()
The commit 91562895f803 ("ext4: properly sync file size update after O_SYNC
direct IO") causes confusion about the meaning of the return value of
ext4_dio_write_end_io().
Specifically, when the ext4_handle_inode_extension() operation succeeds,
ext4_dio_write_end_io() directly returns count instead of 0.
This does not cause a bug in the current kernel, but the semantics of the
return value of the ext4_dio_write_end_io() function are wrong, which is
likely to introduce bugs in the future code evolution.
Signed-off-by: Jinliang Zheng <[email protected]>
Reviewed-by: Zhang Yi <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Theodore Ts'o <[email protected]>
Diffstat (limited to 'fs/jbd2/commit.c')
0 files changed, 0 insertions, 0 deletions