diff options
| author | Jonathan Corbet <[email protected]> | 2006-09-25 23:25:37 +0000 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2006-09-26 00:38:36 +0000 |
| commit | b7de567bf3187ccf776e2fe0e241593cdcba5459 (patch) | |
| tree | c9420517d6a133121d13395dd21b729e6b26f40a /fs/jbd/commit.c | |
| parent | [PATCH] load_module: no BUG if module_subsys uninitialized (diff) | |
| download | kernel-b7de567bf3187ccf776e2fe0e241593cdcba5459.tar.gz kernel-b7de567bf3187ccf776e2fe0e241593cdcba5459.zip | |
[PATCH] VIDIOC_ENUMSTD bug
The v4l2 API documentation for VIDIOC_ENUMSTD says:
To enumerate all standards applications shall begin at index
zero, incrementing by one until the driver returns EINVAL.
The actual code, however, tests the index this way:
if (index<=0 || index >= vfd->tvnormsize) {
ret=-EINVAL;
So any application which passes in index=0 gets EINVAL right off the bat
- and, in fact, this is what happens to mplayer. So I think the
following patch is called for, and maybe even appropriate for a 2.6.18.x
stable release.
Signed-off-by: Jonathan Corbet <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'fs/jbd/commit.c')
0 files changed, 0 insertions, 0 deletions
