diff options
| author | Will Deacon <[email protected]> | 2010-07-02 15:41:52 +0000 |
|---|---|---|
| committer | Russell King <[email protected]> | 2010-07-04 22:11:37 +0000 |
| commit | 446a5a8b1eb91a6990e5c8fe29f14e7a95b69132 (patch) | |
| tree | dd60d5a5db4438d66e0baa78acda85f7be4fbae6 /fs/jbd/commit.c | |
| parent | ARM: 6202/1: Do not ARM_DMA_MEM_BUFFERABLE on RealView boards with L210/L220 (diff) | |
| download | kernel-446a5a8b1eb91a6990e5c8fe29f14e7a95b69132.tar.gz kernel-446a5a8b1eb91a6990e5c8fe29f14e7a95b69132.zip | |
ARM: 6205/1: perf: ensure counter delta is treated as unsigned
Hardware performance counters on ARM are 32-bits wide but atomic64_t
variables are used to represent counter data in the hw_perf_event structure.
The armpmu_event_update function right-shifts a signed 64-bit delta variable
and adds the result to the event count. This can lead to shifting in sign-bits
if the MSB of the 32-bit counter value is set. This results in perf output
such as:
Performance counter stats for 'sleep 20':
18446744073460670464 cycles <-- 0xFFFFFFFFF12A6000
7783773 instructions # 0.000 IPC
465 context-switches
161 page-faults
1172393 branches
20.154242147 seconds time elapsed
This patch ensures that the delta value is treated as unsigned so that the
right shift sets the upper bits to zero.
Cc: <[email protected]>
Acked-by: Jamie Iles <[email protected]>
Signed-off-by: Will Deacon <[email protected]>
Signed-off-by: Russell King <[email protected]>
Diffstat (limited to 'fs/jbd/commit.c')
0 files changed, 0 insertions, 0 deletions
