diff options
| author | Jiapeng Chong <[email protected]> | 2024-08-30 07:17:13 +0000 |
|---|---|---|
| committer | Theodore Ts'o <[email protected]> | 2024-11-13 04:54:13 +0000 |
| commit | c7f9a6fa405248bbd2a398c91d4df30b399f84aa (patch) | |
| tree | 128e4303905e0a49a6a59004cc3580dcd4dbe43d /fs/ext4/fast_commit.c | |
| parent | ext4: fix FS_IOC_GETFSMAP handling (diff) | |
| download | kernel-c7f9a6fa405248bbd2a398c91d4df30b399f84aa.tar.gz kernel-c7f9a6fa405248bbd2a398c91d4df30b399f84aa.zip | |
ext4: simplify if condition
The if condition !A || A && B can be simplified to !A || B.
./fs/ext4/fast_commit.c:362:21-23: WARNING !A || A && B is equivalent to !A || B.
Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9837
Signed-off-by: Jiapeng Chong <[email protected]>
Reviewed-by: Jan Kara <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Theodore Ts'o <[email protected]>
Diffstat (limited to 'fs/ext4/fast_commit.c')
| -rw-r--r-- | fs/ext4/fast_commit.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c index b33664f6ce2a..3dee94a38a68 100644 --- a/fs/ext4/fast_commit.c +++ b/fs/ext4/fast_commit.c @@ -357,9 +357,7 @@ void ext4_fc_mark_ineligible(struct super_block *sb, int reason, handle_t *handl } spin_lock(&sbi->s_fc_lock); is_ineligible = ext4_test_mount_flag(sb, EXT4_MF_FC_INELIGIBLE); - if (has_transaction && - (!is_ineligible || - (is_ineligible && tid_gt(tid, sbi->s_fc_ineligible_tid)))) + if (has_transaction && (!is_ineligible || tid_gt(tid, sbi->s_fc_ineligible_tid))) sbi->s_fc_ineligible_tid = tid; ext4_set_mount_flag(sb, EXT4_MF_FC_INELIGIBLE); spin_unlock(&sbi->s_fc_lock); |