diff options
| author | Eric Biggers <[email protected]> | 2020-10-31 00:45:56 +0000 |
|---|---|---|
| committer | Eric Biggers <[email protected]> | 2020-11-06 17:48:55 +0000 |
| commit | 92cfcd030e4b1de11a6b1edb0840e55c26332d31 (patch) | |
| tree | 73b98ccd1c786537e0455cd239503a0871d545f1 /fs/crypto/inline_crypt.c | |
| parent | Linux 5.10-rc2 (diff) | |
| download | kernel-92cfcd030e4b1de11a6b1edb0840e55c26332d31.tar.gz kernel-92cfcd030e4b1de11a6b1edb0840e55c26332d31.zip | |
fscrypt: remove reachable WARN in fscrypt_setup_iv_ino_lblk_32_key()
I_CREATING isn't actually set until the inode has been assigned an inode
number and inserted into the inode hash table. So the WARN_ON() in
fscrypt_setup_iv_ino_lblk_32_key() is wrong, and it can trigger when
creating an encrypted file on ext4. Remove it.
This was sometimes causing xfstest generic/602 to fail on ext4. I
didn't notice it before because due to a separate oversight, new inodes
that haven't been assigned an inode number yet don't necessarily have
i_ino == 0 as I had thought, so by chance I never saw the test fail.
Fixes: a992b20cd4ee ("fscrypt: add fscrypt_prepare_new_inode() and fscrypt_set_context()")
Reported-by: Theodore Y. Ts'o <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Eric Biggers <[email protected]>
Diffstat (limited to 'fs/crypto/inline_crypt.c')
0 files changed, 0 insertions, 0 deletions