diff options
| author | Johannes Thumshirn <[email protected]> | 2023-05-31 11:50:30 +0000 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2023-05-31 15:50:02 +0000 |
| commit | 6eea4ff8528d6a5b9f0eeb47992e48a8f44b5b8f (patch) | |
| tree | 7c9e61498a3deaf50d03655d2ed1c0cc85f2ea09 /fs/btrfs/dev-replace.c | |
| parent | md: raid5-log: use __bio_add_page to add single page (diff) | |
| download | kernel-6eea4ff8528d6a5b9f0eeb47992e48a8f44b5b8f.tar.gz kernel-6eea4ff8528d6a5b9f0eeb47992e48a8f44b5b8f.zip | |
md: raid5: use __bio_add_page to add single page to new bio
The raid5-ppl submission code uses bio_add_page() to add a page to a
newly created bio. bio_add_page() can fail, but the return value is never
checked. For adding consecutive pages, the return is actually checked and
a new bio is allocated if adding the page fails.
Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.
This brings us a step closer to marking bio_add_page() as __must_check.
Reviewed-by: Christoph Hellwig <[email protected]>
Reviewed-by: Damien Le Moal <[email protected]>
Acked-by: Song Liu <[email protected]>
Signed-off-by: Johannes Thumshirn <[email protected]>
Link: https://lore.kernel.org/r/27e6bcd762354bff74602e89159cdd12ae3d1fa9.1685532726.git.johannes.thumshirn@wdc.com
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'fs/btrfs/dev-replace.c')
0 files changed, 0 insertions, 0 deletions
