aboutsummaryrefslogtreecommitdiffstats
path: root/fs/btrfs/dev-replace.c
diff options
context:
space:
mode:
authorZhaolei <[email protected]>2015-08-17 10:44:45 +0000
committerChris Mason <[email protected]>2015-08-19 21:24:49 +0000
commit34eb2a524997e5cd7117569b1fda925516adf6ac (patch)
treeb7d17e3f6a4e78fc51acac6a9260ee901536de05 /fs/btrfs/dev-replace.c
parentMerge branch 'jeffm-discard-4.3' into for-linus-4.3 (diff)
downloadkernel-34eb2a524997e5cd7117569b1fda925516adf6ac.tar.gz
kernel-34eb2a524997e5cd7117569b1fda925516adf6ac.zip
btrfs: Remove useless condition in start_log_trans()
Dan Carpenter <[email protected]> reported a smatch warning for start_log_trans(): fs/btrfs/tree-log.c:178 start_log_trans() warn: we tested 'root->log_root' before and it was 'false' fs/btrfs/tree-log.c 147 if (root->log_root) { We test "root->log_root" here. ... Reason: Condition of: fs/btrfs/tree-log.c:178: if (!root->log_root) { is not necessary after commit: 7237f1833 It caused a smatch warning, and no functionally error. Fix: Deleting above condition will make smatch shut up, but a better way is to do cleanup for start_log_trans() to remove duplicated code and make code more readable. Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Zhao Lei <[email protected]> Signed-off-by: Chris Mason <[email protected]>
Diffstat (limited to 'fs/btrfs/dev-replace.c')
0 files changed, 0 insertions, 0 deletions