diff options
| author | Xu Yang <[email protected]> | 2025-08-11 09:29:31 +0000 |
|---|---|---|
| committer | Paolo Abeni <[email protected]> | 2025-08-14 08:09:28 +0000 |
| commit | 4faff70959d51078f9ee8372f8cff0d7045e4114 (patch) | |
| tree | b698647f50a7eb24c49324ebea556fae6a42f9da /drivers | |
| parent | net: kcm: Fix race condition in kcm_unattach() (diff) | |
| download | kernel-4faff70959d51078f9ee8372f8cff0d7045e4114.tar.gz kernel-4faff70959d51078f9ee8372f8cff0d7045e4114.zip | |
net: usb: asix_devices: add phy_mask for ax88772 mdio bus
Without setting phy_mask for ax88772 mdio bus, current driver may create
at most 32 mdio phy devices with phy address range from 0x00 ~ 0x1f.
DLink DUB-E100 H/W Ver B1 is such a device. However, only one main phy
device will bind to net phy driver. This is creating issue during system
suspend/resume since phy_polling_mode() in phy_state_machine() will
directly deference member of phydev->drv for non-main phy devices. Then
NULL pointer dereference issue will occur. Due to only external phy or
internal phy is necessary, add phy_mask for ax88772 mdio bus to workarnoud
the issue.
Closes: https://lore.kernel.org/netdev/[email protected]
Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support")
Cc: [email protected]
Signed-off-by: Xu Yang <[email protected]>
Tested-by: Oleksij Rempel <[email protected]>
Reviewed-by: Oleksij Rempel <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Paolo Abeni <[email protected]>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/usb/asix_devices.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c index 9b0318fb50b5..d9f5942ccc44 100644 --- a/drivers/net/usb/asix_devices.c +++ b/drivers/net/usb/asix_devices.c @@ -676,6 +676,7 @@ static int ax88772_init_mdio(struct usbnet *dev) priv->mdio->read = &asix_mdio_bus_read; priv->mdio->write = &asix_mdio_bus_write; priv->mdio->name = "Asix MDIO Bus"; + priv->mdio->phy_mask = ~(BIT(priv->phy_addr) | BIT(AX_EMBD_PHY_ADDR)); /* mii bus name is usb-<usb bus number>-<usb device number> */ snprintf(priv->mdio->id, MII_BUS_ID_SIZE, "usb-%03d:%03d", dev->udev->bus->busnum, dev->udev->devnum); |