diff options
| author | Douglas Anderson <[email protected]> | 2016-01-29 02:19:56 +0000 |
|---|---|---|
| committer | Felipe Balbi <[email protected]> | 2016-03-04 13:14:40 +0000 |
| commit | 94ef7aee11c26e79441276ca43f0c25a04bd1303 (patch) | |
| tree | 8d2a41f930cc138f67b8ab12fef28b9c19545961 /drivers/usb/dwc2/hcd_queue.c | |
| parent | usb: dwc2: host: Avoid use of chan->qh after qh freed (diff) | |
| download | kernel-94ef7aee11c26e79441276ca43f0c25a04bd1303.tar.gz kernel-94ef7aee11c26e79441276ca43f0c25a04bd1303.zip | |
usb: dwc2: host: Always add to the tail of queues
The queues the the dwc2 host controller used are truly queues. That
means FIFO or first in first out.
Unfortunately though the code was iterating through these queues
starting from the head, some places in the code was adding things to the
queue by adding at the head instead of the tail. That means last in
first out. Doh.
Go through and just always add to the tail.
Doing this makes things much happier when I've got:
* 7-port USB 2.0 Single-TT hub
* - Microsoft 2.4 GHz Transceiver v7.0 dongle
* - Jabra speakerphone playing music
Acked-by: John Youn <[email protected]>
Signed-off-by: Douglas Anderson <[email protected]>
Reviewed-by: Kever Yang <[email protected]>
Tested-by: Heiko Stuebner <[email protected]>
Tested-by: Stefan Wahren <[email protected]>
Signed-off-by: Felipe Balbi <[email protected]>
Diffstat (limited to 'drivers/usb/dwc2/hcd_queue.c')
| -rw-r--r-- | drivers/usb/dwc2/hcd_queue.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/usb/dwc2/hcd_queue.c b/drivers/usb/dwc2/hcd_queue.c index e0933a9dfad7..bc632a72f611 100644 --- a/drivers/usb/dwc2/hcd_queue.c +++ b/drivers/usb/dwc2/hcd_queue.c @@ -732,9 +732,11 @@ void dwc2_hcd_qh_deactivate(struct dwc2_hsotg *hsotg, struct dwc2_qh *qh, dwc2_frame_num_le(qh->sched_frame, frame_number)) || (hsotg->core_params->uframe_sched <= 0 && qh->sched_frame == frame_number)) - list_move(&qh->qh_list_entry, &hsotg->periodic_sched_ready); + list_move_tail(&qh->qh_list_entry, + &hsotg->periodic_sched_ready); else - list_move(&qh->qh_list_entry, &hsotg->periodic_sched_inactive); + list_move_tail(&qh->qh_list_entry, + &hsotg->periodic_sched_inactive); } /** |