diff options
| author | Quentin Casasnovas <[email protected]> | 2015-04-14 09:25:43 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2015-04-28 10:53:16 +0000 |
| commit | 0d3bba0287d4e284c3ec7d3397e81eec920d5e7e (patch) | |
| tree | b41e9c9a3992a140837df671e9cef3fe64e49667 /drivers/usb/chipidea/debug.c | |
| parent | Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap" (diff) | |
| download | kernel-0d3bba0287d4e284c3ec7d3397e81eec920d5e7e.tar.gz kernel-0d3bba0287d4e284c3ec7d3397e81eec920d5e7e.zip | |
cdc-acm: prevent infinite loop when parsing CDC headers.
Phil and I found out a problem with commit:
7e860a6e7aa6 ("cdc-acm: add sanity checks")
It added some sanity checks to ignore potential garbage in CDC headers but
also introduced a potential infinite loop. This can happen at the first
loop iteration (elength = 0 in that case) if the description isn't a
DT_CS_INTERFACE or later if 'buffer[0]' is zero.
It should also be noted that the wrong length was being added to 'buffer'
in case 'buffer[1]' was not a DT_CS_INTERFACE descriptor, since elength was
assigned after that check in the loop.
A specially crafted USB device could be used to trigger this infinite loop.
Fixes: 7e860a6e7aa6 ("cdc-acm: add sanity checks")
Signed-off-by: Phil Turnbull <[email protected]>
Signed-off-by: Quentin Casasnovas <[email protected]>
CC: Sergei Shtylyov <[email protected]>
CC: Oliver Neukum <[email protected]>
CC: Adam Lee <[email protected]>
CC: <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'drivers/usb/chipidea/debug.c')
0 files changed, 0 insertions, 0 deletions
