aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/cdns3/cdns3-ti.c
diff options
context:
space:
mode:
authorEugeniu Rosca <[email protected]>2019-09-09 10:54:39 +0000
committerFelipe Balbi <[email protected]>2019-10-22 07:30:59 +0000
commit8b20d00f0f089b72f0a1e08d602a29f874bb0a35 (patch)
tree7fb6d7781d614134566f7ba3d6cbdd8c65b258ef /drivers/usb/cdns3/cdns3-ti.c
parentusb: gadget: udc: renesas_usb3: add suspend event support (diff)
downloadkernel-8b20d00f0f089b72f0a1e08d602a29f874bb0a35.tar.gz
kernel-8b20d00f0f089b72f0a1e08d602a29f874bb0a35.zip
usb: renesas_usbhs: enable DVSE interrupt
Commit [1] enabled the possibility of checking the DVST (Device State Transition) bit of INTSTS0 (Interrupt Status Register 0) and calling the irq_dev_state() handler if the DVST bit is set. But neither commit [1] nor commit [2] actually enabled the DVSE (Device State Transition Interrupt Enable) bit in the INTENB0 (Interrupt Enable Register 0). As a consequence, irq_dev_state() handler is getting called as a side effect of other (non-DVSE) interrupts being fired, which definitely can't be relied upon, if DVST notifications are of any value. Why this doesn't hurt is because usbhsg_irq_dev_state() currently doesn't do much except of a dev_dbg(). Once more work is added to the handler (e.g. detecting device "Suspended" state and notifying other USB gadget components about it), enabling DVSE becomes a hard requirement. Do it in a standalone commit for better visibility and clear explanation. [1] f1407d5 ("usb: renesas_usbhs: Add Renesas USBHS common code") [2] 2f98382 ("usb: renesas_usbhs: Add Renesas USBHS Gadget") Signed-off-by: Eugeniu Rosca <[email protected]> Signed-off-by: Veeraiyan Chidambaram <[email protected]> Signed-off-by: Felipe Balbi <[email protected]>
Diffstat (limited to 'drivers/usb/cdns3/cdns3-ti.c')
0 files changed, 0 insertions, 0 deletions