diff options
| author | Manikanta Mylavarapu <[email protected]> | 2024-10-16 14:48:52 +0000 |
|---|---|---|
| committer | Bjorn Andersson <[email protected]> | 2024-10-24 14:46:20 +0000 |
| commit | 128fdbf36cddc2a901c4889ba1c89fa9f2643f2c (patch) | |
| tree | c7833448278a5d661d9cc5c7c3e5fe5d103a0eec /drivers/usb/cdns3/cdns3-ti.c | |
| parent | firmware: qcom: scm: Return -EOPNOTSUPP for unsupported SHM bridge enabling (diff) | |
| download | kernel-128fdbf36cddc2a901c4889ba1c89fa9f2643f2c.tar.gz kernel-128fdbf36cddc2a901c4889ba1c89fa9f2643f2c.zip | |
soc: qcom: socinfo: fix revision check in qcom_socinfo_probe()
In success case, the revision holds a non-null pointer. The current
logic incorrectly returns an error for a non-null pointer, whereas
it should return an error for a null pointer.
The socinfo driver for IPQ9574 and IPQ5332 is currently broken,
resulting in the following error message
qcom-socinfo qcom-socinfo: probe with driver qcom-socinfo failed with
error -12
Add a null check for the revision to ensure it returns an error only in
failure case (null pointer).
Fixes: e694d2b5c58b ("soc: qcom: Add check devm_kasprintf() returned value")
Signed-off-by: Manikanta Mylavarapu <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Bjorn Andersson <[email protected]>
Diffstat (limited to 'drivers/usb/cdns3/cdns3-ti.c')
0 files changed, 0 insertions, 0 deletions
