diff options
| author | Dan Williams <[email protected]> | 2012-06-22 06:36:20 +0000 |
|---|---|---|
| committer | James Bottomley <[email protected]> | 2012-07-20 07:58:53 +0000 |
| commit | b17caa174a7e1fd2e17b26e210d4ee91c4c28b37 (patch) | |
| tree | 5ecdb47d968389d9386e5e5c96fe647a8bb04e7b /drivers/scsi/libsas/sas_init.c | |
| parent | [SCSI] libsas: continue revalidation (diff) | |
| download | kernel-b17caa174a7e1fd2e17b26e210d4ee91c4c28b37.tar.gz kernel-b17caa174a7e1fd2e17b26e210d4ee91c4c28b37.zip | |
[SCSI] libsas: fix sas_discover_devices return code handling
commit 198439e4 [SCSI] libsas: do not set res = 0 in sas_ex_discover_dev()
commit 19252de6 [SCSI] libsas: fix wide port hotplug issues
The above commits seem to have confused the return value of
sas_ex_discover_dev which is non-zero on failure and
sas_ex_join_wide_port which just indicates short circuiting discovery on
already established ports. The result is random discovery failures
depending on configuration.
Calls to sas_ex_join_wide_port are the source of the trouble as its
return value is errantly assigned to 'res'. Convert it to bool and stop
returning its result up the stack.
Cc: <[email protected]>
Tested-by: Dan Melnic <[email protected]>
Reported-by: Dan Melnic <[email protected]>
Signed-off-by: Dan Williams <[email protected]>
Reviewed-by: Jack Wang <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
Diffstat (limited to 'drivers/scsi/libsas/sas_init.c')
0 files changed, 0 insertions, 0 deletions
