diff options
| author | Arnd Bergmann <[email protected]> | 2017-03-28 14:22:03 +0000 |
|---|---|---|
| committer | Martin K. Petersen <[email protected]> | 2017-03-30 02:44:53 +0000 |
| commit | 8bb74d36613322ac473ff6e3d8559c66ca531533 (patch) | |
| tree | 742c9e1fc5a4fdb7b5ab3bf496c9e1e11ab2bbeb /drivers/scsi/libsas/sas_init.c | |
| parent | scsi: ufs: just use sizeof() for snprintf() (diff) | |
| download | kernel-8bb74d36613322ac473ff6e3d8559c66ca531533.tar.gz kernel-8bb74d36613322ac473ff6e3d8559c66ca531533.zip | |
scsi: hisi_sas: fix SATA dependency
Removing the 'select SCSI_SAS_LIBSAS' statement in Kconfig resulted in a
link failure in configurations that have hisi_sas built-in but libsas as
a loadable module:
drivers/scsi/built-in.o: In function `hisi_sas_scan_finished':
hisi_sas_main.c:(.text+0x37ce9): undefined reference to `sas_drain_work'
drivers/scsi/built-in.o: In function `hisi_sas_slave_configure':
hisi_sas_main.c:(.text+0x37d17): undefined reference to `sas_slave_configure'
hisi_sas_main.c:(.text+0x37d40): undefined reference to `sas_change_queue_depth'
drivers/scsi/built-in.o: In function `hisi_sas_remove':
All other libsas users have the 'select' statement, so we should do the
same here for consistency. For all I can tell, the patch that added the
sata softreset does not actually introduce a dependency on SCSI_SAS_ATA
but instead adds calls into libata itself, so we can express that with a
more specific dependency.
We cannot have 'select SCSI_SAS_LIBSAS; depends on SCSI_SAS_ATA' as that
would cause a dependency loop.
Fixes: 7c594f0407de ("scsi: hisi_sas: add softreset function for SATA disk")
Signed-off-by: Arnd Bergmann <[email protected]>
Acked-by: John Garry <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
Diffstat (limited to 'drivers/scsi/libsas/sas_init.c')
0 files changed, 0 insertions, 0 deletions
