diff options
| author | Tom Rix <[email protected]> | 2022-06-27 20:59:43 +0000 |
|---|---|---|
| committer | Alexandre Belloni <[email protected]> | 2022-07-26 14:31:15 +0000 |
| commit | 03d7a732815069a78c8c655092e48fcdd52734fb (patch) | |
| tree | a1ce262a0666a3b23b7ff9a28f8b95436ded758f /drivers/rtc/rtc-mpfs.c | |
| parent | rtc: rv8803: fix missing unlock on error in rv8803_set_time() (diff) | |
| download | kernel-03d7a732815069a78c8c655092e48fcdd52734fb.tar.gz kernel-03d7a732815069a78c8c655092e48fcdd52734fb.zip | |
rtc: mpfs: remove 'pending' variable from mpfs_rtc_wakeup_irq_handler()
cppcheck reports
[drivers/rtc/rtc-mpfs.c:219]: (style) Variable 'pending' is assigned a value that is never used.
The fetched CONTROL_REG stored in pending is unused and partially
duplicates the functionality of the later call to mpfs_rtc_clear(). This looks
like leftover development code, so remove pending.
Fixes: 0b31d703598d ("rtc: Add driver for Microchip PolarFire SoC")
Signed-off-by: Tom Rix <[email protected]>
Reviewed-by: Conor Dooley <[email protected]>
Signed-off-by: Alexandre Belloni <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Diffstat (limited to 'drivers/rtc/rtc-mpfs.c')
| -rw-r--r-- | drivers/rtc/rtc-mpfs.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/rtc/rtc-mpfs.c b/drivers/rtc/rtc-mpfs.c index db9c638e50f7..f14d1925e0c9 100644 --- a/drivers/rtc/rtc-mpfs.c +++ b/drivers/rtc/rtc-mpfs.c @@ -213,10 +213,7 @@ static inline struct clk *mpfs_rtc_init_clk(struct device *dev) static irqreturn_t mpfs_rtc_wakeup_irq_handler(int irq, void *dev) { struct mpfs_rtc_dev *rtcdev = dev; - unsigned long pending; - pending = readl(rtcdev->base + CONTROL_REG); - pending &= CONTROL_ALARM_ON_BIT; mpfs_rtc_clear_irq(rtcdev); rtc_update_irq(rtcdev->rtc, 1, RTC_IRQF | RTC_AF); |