diff options
| author | Marcelo Roberto Jimenez <[email protected]> | 2011-02-02 18:04:02 +0000 |
|---|---|---|
| committer | John Stultz <[email protected]> | 2011-02-03 20:59:50 +0000 |
| commit | 83a06bf50bdf2074b9404951ff60e142d159d93b (patch) | |
| tree | ebb70cdc221d06529fd327e284f1b9191939f6aa /drivers/rtc/interface.c | |
| parent | Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rol... (diff) | |
| download | kernel-83a06bf50bdf2074b9404951ff60e142d159d93b.tar.gz kernel-83a06bf50bdf2074b9404951ff60e142d159d93b.zip | |
RTC: Prevents a division by zero in kernel code.
This patch prevents a user space program from calling the RTC_IRQP_SET
ioctl with a negative value of frequency. Also, if this call is make
with a zero value of frequency, there would be a division by zero in the
kernel code.
[jstultz: Also initialize irq_freq to 1 to catch other divbyzero issues]
CC: Alessandro Zummo <[email protected]>
CC: Thomas Gleixner <[email protected]>
Signed-off-by: Marcelo Roberto Jimenez <[email protected]>
Signed-off-by: John Stultz <[email protected]>
Diffstat (limited to 'drivers/rtc/interface.c')
| -rw-r--r-- | drivers/rtc/interface.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c index 925006d33109..a0c01967244d 100644 --- a/drivers/rtc/interface.c +++ b/drivers/rtc/interface.c @@ -464,6 +464,9 @@ int rtc_irq_set_freq(struct rtc_device *rtc, struct rtc_task *task, int freq) int err = 0; unsigned long flags; + if (freq <= 0) + return -EINVAL; + spin_lock_irqsave(&rtc->irq_task_lock, flags); if (rtc->irq_task != NULL && task == NULL) err = -EBUSY; |