diff options
| author | Uwe Kleine-König <[email protected]> | 2019-08-24 15:37:04 +0000 |
|---|---|---|
| committer | Thierry Reding <[email protected]> | 2019-09-20 23:48:55 +0000 |
| commit | 797a5ebc26daee5552e668ee4622bc3f47c1f743 (patch) | |
| tree | 71b37f222dc6144a51493500b9becfb7d1698375 /drivers/pwm/pwm-rockchip.c | |
| parent | pwm: Let pwm_get_state() return the last implemented state (diff) | |
| download | kernel-797a5ebc26daee5552e668ee4622bc3f47c1f743.tar.gz kernel-797a5ebc26daee5552e668ee4622bc3f47c1f743.zip | |
pwm: rockchip: Don't update the state for the caller of pwm_apply_state()
The pwm-rockchip driver is one of only three PWM drivers which updates
the state for the caller of pwm_apply_state(). This might have
surprising results if the caller reuses the values expecting them to
still represent the same state.
Signed-off-by: Uwe Kleine-König <[email protected]>
Signed-off-by: Thierry Reding <[email protected]>
Diffstat (limited to 'drivers/pwm/pwm-rockchip.c')
| -rw-r--r-- | drivers/pwm/pwm-rockchip.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c index 8eb2db59741d..83c7627868d8 100644 --- a/drivers/pwm/pwm-rockchip.c +++ b/drivers/pwm/pwm-rockchip.c @@ -212,12 +212,6 @@ static int rockchip_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, goto out; } - /* - * Update the state with the real hardware, which can differ a bit - * because of period/duty_cycle approximation. - */ - rockchip_pwm_get_state(chip, pwm, state); - out: clk_disable(pc->pclk); |