aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/pwm/pwm-img.c
diff options
context:
space:
mode:
authorUwe Kleine-König <[email protected]>2021-07-07 16:27:51 +0000
committerThierry Reding <[email protected]>2021-09-02 19:38:36 +0000
commitc68eb29c8e9067c08175dd0414f6984f236f719d (patch)
treeba818bea64a87186f6aa8e27fae6b7f858307fc2 /drivers/pwm/pwm-img.c
parentpwm: mxs: Don't modify HW state in .probe() after the PWM chip was registered (diff)
downloadkernel-c68eb29c8e9067c08175dd0414f6984f236f719d.tar.gz
kernel-c68eb29c8e9067c08175dd0414f6984f236f719d.zip
pwm: img: Don't modify HW state in .remove() callback
A consumer is expected to disable a PWM before calling pwm_put(). And if they didn't there is hopefully a good reason (or the consumer needs fixing). Also if disabling an enabled PWM was the right thing to do, this should better be done in the framework instead of in each low level driver. Signed-off-by: Uwe Kleine-König <[email protected]> Signed-off-by: Thierry Reding <[email protected]>
Diffstat (limited to 'drivers/pwm/pwm-img.c')
-rw-r--r--drivers/pwm/pwm-img.c16
1 files changed, 0 insertions, 16 deletions
diff --git a/drivers/pwm/pwm-img.c b/drivers/pwm/pwm-img.c
index 11b16ecc4f96..18d8e34d0d08 100644
--- a/drivers/pwm/pwm-img.c
+++ b/drivers/pwm/pwm-img.c
@@ -326,23 +326,7 @@ err_pm_disable:
static int img_pwm_remove(struct platform_device *pdev)
{
struct img_pwm_chip *pwm_chip = platform_get_drvdata(pdev);
- u32 val;
- unsigned int i;
- int ret;
-
- ret = pm_runtime_get_sync(&pdev->dev);
- if (ret < 0) {
- pm_runtime_put(&pdev->dev);
- return ret;
- }
-
- for (i = 0; i < pwm_chip->chip.npwm; i++) {
- val = img_pwm_readl(pwm_chip, PWM_CTRL_CFG);
- val &= ~BIT(i);
- img_pwm_writel(pwm_chip, PWM_CTRL_CFG, val);
- }
- pm_runtime_put(&pdev->dev);
pm_runtime_disable(&pdev->dev);
if (!pm_runtime_status_suspended(&pdev->dev))
img_pwm_runtime_suspend(&pdev->dev);