diff options
| author | Kurt Borja <[email protected]> | 2025-01-05 15:30:04 +0000 |
|---|---|---|
| committer | Ilpo Järvinen <[email protected]> | 2025-01-09 11:40:35 +0000 |
| commit | 1d334211aa60560cdc3995b183e601c44cf722b5 (patch) | |
| tree | 3ce60e0183f99c8c6ab07982fde7dbfd63a98938 /drivers/platform/x86/intel/punit_ipc.c | |
| parent | platform/x86: alienware-wmi: Modify parse_rgb() signature (diff) | |
| download | kernel-1d334211aa60560cdc3995b183e601c44cf722b5.tar.gz kernel-1d334211aa60560cdc3995b183e601c44cf722b5.zip | |
platform/x86: alienware-wmi: Improve hdmi_mux, amplifier and deepslp group creation
Devices with hdmi_mux, amplifier or deepslp quirks create a sysfs group
for each available feature. To accomplish this, helper create/remove
functions were called on module init, but they had the following
problems:
- Create helpers called remove helpers on failure, which in turn tried
to remove the sysfs group that failed to be created
- If group creation failed mid way, previous successfully created groups
were not cleaned up
- Module exit only removed hdmi_mux group
To improve this, drop all helpers and let the platform driver manage these
sysfs groups, while controlling visibility with their respective quirks.
Reviewed-by: Armin Wolf <[email protected]>
Reviewed-by: Mario Limonciello <[email protected]>
Signed-off-by: Kurt Borja <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Ilpo Järvinen <[email protected]>
Signed-off-by: Ilpo Järvinen <[email protected]>
Diffstat (limited to 'drivers/platform/x86/intel/punit_ipc.c')
0 files changed, 0 insertions, 0 deletions
