diff options
| author | Janne Grunau <[email protected]> | 2025-04-01 09:17:01 +0000 |
|---|---|---|
| committer | Manivannan Sadhasivam <[email protected]> | 2025-04-19 14:53:51 +0000 |
| commit | 751bec089c4eed486578994abd2c5395f08d0302 (patch) | |
| tree | 5599db936c4dee2aa74d8ef3ec7634d046323897 /drivers/pci/controller/pcie-apple.c | |
| parent | Linux 6.15-rc1 (diff) | |
| download | kernel-751bec089c4eed486578994abd2c5395f08d0302.tar.gz kernel-751bec089c4eed486578994abd2c5395f08d0302.zip | |
PCI: apple: Set only available ports up
Iterating over disabled ports results in of_irq_parse_raw() parsing
the wrong "interrupt-map" entries, as it takes the status of the node
into account.
This became apparent after disabling unused PCIe ports in the Apple
Silicon device trees instead of deleting them.
Switching from for_each_child_of_node_scoped() to
for_each_available_child_of_node_scoped() solves this issue.
Fixes: 1e33888fbe44 ("PCI: apple: Add initial hardware bring-up")
Fixes: a0189fdfb73d ("arm64: dts: apple: t8103: Disable unused PCIe ports")
Signed-off-by: Janne Grunau <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Signed-off-by: Manivannan Sadhasivam <[email protected]>
Tested-by: Janne Grunau <[email protected]>
Reviewed-by: Rob Herring (Arm) <[email protected]>
Reviewed-by: Manivannan Sadhasivam <[email protected]>
Acked-by: Alyssa Rosenzweig <[email protected]>
Cc: [email protected]
Link: https://lore.kernel.org/asahi/20230214-apple_dts_pcie_disable_unused-v1-0-5ea0d3ddcde3@jannau.net/
Link: https://lore.kernel.org/asahi/[email protected]/
Link: https://patch.msgid.link/[email protected]
Diffstat (limited to 'drivers/pci/controller/pcie-apple.c')
| -rw-r--r-- | drivers/pci/controller/pcie-apple.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c index 18e11b9a7f46..996cef8a2e17 100644 --- a/drivers/pci/controller/pcie-apple.c +++ b/drivers/pci/controller/pcie-apple.c @@ -754,7 +754,7 @@ static int apple_pcie_init(struct pci_config_window *cfg) if (ret) return ret; - for_each_child_of_node_scoped(dev->of_node, of_port) { + for_each_available_child_of_node_scoped(dev->of_node, of_port) { ret = apple_pcie_setup_port(pcie, of_port); if (ret) { dev_err(pcie->dev, "Port %pOF setup fail: %d\n", of_port, ret); |
