diff options
| author | Peter Zijlstra <[email protected]> | 2021-02-18 16:14:10 +0000 |
|---|---|---|
| committer | Thomas Gleixner <[email protected]> | 2021-02-22 18:54:09 +0000 |
| commit | 724c8a23d589d8a002d2e39633c2f9a5a429616f (patch) | |
| tree | 623c789a1ed733adbc2d11b50449f08a7d95404b /drivers/pci/controller/dwc | |
| parent | um: Enforce the usage of asm-generic/softirq_stack.h (diff) | |
| download | kernel-724c8a23d589d8a002d2e39633c2f9a5a429616f.tar.gz kernel-724c8a23d589d8a002d2e39633c2f9a5a429616f.zip | |
objtool: Fix stack-swizzle for FRAME_POINTER=y
When objtool encounters the stack-swizzle:
mov %rsp, (%[tos])
mov %[tos], %rsp
...
pop %rsp
Inside a FRAME_POINTER=y build, things go a little screwy because
clearly we're not adjusting the cfa->base. This then results in the
pop %rsp not being detected as a restore of cfa->base so it will turn
into a regular POP and offset the stack, resulting in:
kernel/softirq.o: warning: objtool: do_softirq()+0xdb: return with modified stack frame
Therefore, have "mov %[tos], %rsp" act like a PUSH (it sorta is
anyway) to balance the things out. We're not too concerned with the
actual stack_size for frame-pointer builds, since we don't generate
ORC data for them anyway.
Fixes: aafeb14e9da2 ("objtool: Support stack-swizzle")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Acked-by: Josh Poimboeuf <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
Diffstat (limited to 'drivers/pci/controller/dwc')
0 files changed, 0 insertions, 0 deletions
