diff options
| author | Yuchung Cheng <[email protected]> | 2017-01-28 00:24:39 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2017-01-30 00:17:23 +0000 |
| commit | 678550c651aee051d66112933c87894f129b9355 (patch) | |
| tree | ed24210650990895c35fbae14f84237f8c0fccd2 /drivers/net/xen-netback/interface.c | |
| parent | tcp: record pkts sent and retransmistted (diff) | |
| download | kernel-678550c651aee051d66112933c87894f129b9355.tar.gz kernel-678550c651aee051d66112933c87894f129b9355.zip | |
tcp: include locally failed retries in retransmission stats
Currently the retransmission stats are not incremented if the
retransmit fails locally. But we always increment the other packet
counters that track total packet/bytes sent. Awkwardly while we
don't count these failed retransmits in RETRANSSEGS, we do count
them in FAILEDRETRANS.
If the qdisc is dropping many packets this could under-estimate
TCP retransmission rate substantially from both SNMP or per-socket
TCP_INFO stats. This patch changes this by always incrementing
retransmission stats on retransmission attempts and failures.
Another motivation is to properly track retransmists in
SCM_TIMESTAMPING_OPT_STATS. Since SCM_TSTAMP_SCHED collection is
triggered in tcp_transmit_skb(), If tp->total_retrans is incremented
after the function, we'll always mis-count by the amount of the
latest retransmission.
Signed-off-by: Yuchung Cheng <[email protected]>
Signed-off-by: Soheil Hassas Yeganeh <[email protected]>
Acked-by: Neal Cardwell <[email protected]>
Acked-by: Eric Dumazet <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/net/xen-netback/interface.c')
0 files changed, 0 insertions, 0 deletions