diff options
| author | Justin Stitt <[email protected]> | 2023-10-09 23:19:57 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2023-10-13 09:18:20 +0000 |
| commit | 431acee069232e8d713d0b9d7e02127ecbecddd6 (patch) | |
| tree | a5c1ff861328578000c0c875fdfdc667502f04c0 /drivers/net/xen-netback/interface.c | |
| parent | net: fec: replace deprecated strncpy with ethtool_sprintf (diff) | |
| download | kernel-431acee069232e8d713d0b9d7e02127ecbecddd6.tar.gz kernel-431acee069232e8d713d0b9d7e02127ecbecddd6.zip | |
ibmvnic: replace deprecated strncpy with strscpy
`strncpy` is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.
NUL-padding is not required as the buffer is already memset to 0:
| memset(adapter->fw_version, 0, 32);
Note that another usage of strscpy exists on the same buffer:
| strscpy((char *)adapter->fw_version, "N/A", sizeof(adapter->fw_version));
Considering the above, a suitable replacement is `strscpy` [2] due to
the fact that it guarantees NUL-termination on the destination buffer
without unnecessarily NUL-padding.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Cc: [email protected]
Signed-off-by: Justin Stitt <[email protected]>
Reviewed-by: Kees Cook <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/net/xen-netback/interface.c')
0 files changed, 0 insertions, 0 deletions
