diff options
| author | Yoshihiro Shimoda <[email protected]> | 2023-10-05 01:12:01 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2023-10-06 23:19:13 +0000 |
| commit | 3971442870713de527684398416970cf025b4f89 (patch) | |
| tree | aad775f9e346ca9fe7e0b661d4165fe5e1954d54 /drivers/net/xen-netback/interface.c | |
| parent | ravb: Fix up dma_free_coherent() call in ravb_remove() (diff) | |
| download | kernel-3971442870713de527684398416970cf025b4f89.tar.gz kernel-3971442870713de527684398416970cf025b4f89.zip | |
ravb: Fix use-after-free issue in ravb_tx_timeout_work()
The ravb_stop() should call cancel_work_sync(). Otherwise,
ravb_tx_timeout_work() is possible to use the freed priv after
ravb_remove() was called like below:
CPU0 CPU1
ravb_tx_timeout()
ravb_remove()
unregister_netdev()
free_netdev(ndev)
// free priv
ravb_tx_timeout_work()
// use priv
unregister_netdev() will call .ndo_stop() so that ravb_stop() is
called. And, after phy_stop() is called, netif_carrier_off()
is also called. So that .ndo_tx_timeout() will not be called
after phy_stop().
Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Reported-by: Zheng Wang <[email protected]>
Closes: https://lore.kernel.org/netdev/[email protected]/
Signed-off-by: Yoshihiro Shimoda <[email protected]>
Reviewed-by: Sergey Shtylyov <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'drivers/net/xen-netback/interface.c')
0 files changed, 0 insertions, 0 deletions
