diff options
| author | Daniel Gabay <[email protected]> | 2024-10-10 11:05:03 +0000 |
|---|---|---|
| committer | Johannes Berg <[email protected]> | 2024-10-25 15:53:29 +0000 |
| commit | 9715246ca0bfc9feaec1b4ff5b3d38de65a7025d (patch) | |
| tree | 8f7a8d24b9010eea9632cd9671e3c1cbbed58b4c /drivers/net/wireless/intel/iwlwifi/fw/init.c | |
| parent | wifi: iwlwifi: mvm: really send iwl_txpower_constraints_cmd (diff) | |
| download | kernel-9715246ca0bfc9feaec1b4ff5b3d38de65a7025d.tar.gz kernel-9715246ca0bfc9feaec1b4ff5b3d38de65a7025d.zip | |
wifi: iwlwifi: mvm: Use the sync timepoint API in suspend
When starting the suspend flow, HOST_D3_START triggers an _async_
firmware dump collection for debugging purposes. The async worker
may race with suspend flow and fail to get NIC access, resulting in
the following warning:
"Timeout waiting for hardware access (CSR_GP_CNTRL 0xffffffff)"
Fix this by switching to the sync version to ensure the dump
completes before proceeding with the suspend flow, avoiding
potential race issues.
Signed-off-by: Daniel Gabay <[email protected]>
Signed-off-by: Miri Korenblit <[email protected]>
Link: https://patch.msgid.link/20241010140328.9aae318cd593.I4b322009f39489c0b1d8893495c887870f73ed9c@changeid
Signed-off-by: Johannes Berg <[email protected]>
Diffstat (limited to 'drivers/net/wireless/intel/iwlwifi/fw/init.c')
| -rw-r--r-- | drivers/net/wireless/intel/iwlwifi/fw/init.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/init.c b/drivers/net/wireless/intel/iwlwifi/fw/init.c index d8b083be5b6b..de87e0e3e072 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/init.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/init.c @@ -39,10 +39,12 @@ void iwl_fw_runtime_init(struct iwl_fw_runtime *fwrt, struct iwl_trans *trans, } IWL_EXPORT_SYMBOL(iwl_fw_runtime_init); +/* Assumes the appropriate lock is held by the caller */ void iwl_fw_runtime_suspend(struct iwl_fw_runtime *fwrt) { iwl_fw_suspend_timestamp(fwrt); - iwl_dbg_tlv_time_point(fwrt, IWL_FW_INI_TIME_POINT_HOST_D3_START, NULL); + iwl_dbg_tlv_time_point_sync(fwrt, IWL_FW_INI_TIME_POINT_HOST_D3_START, + NULL); } IWL_EXPORT_SYMBOL(iwl_fw_runtime_suspend); |