diff options
| author | Sebastian Andrzej Siewior <[email protected]> | 2020-09-29 20:25:37 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2020-09-29 21:02:55 +0000 |
| commit | e4ff7d6b8cee30a823347df8651444f8fa20b320 (patch) | |
| tree | b892b62a1fbfa0647b06499929f8633328f5cb50 /drivers/net/wireless/intel/iwlegacy/common.h | |
| parent | net: brcmfmac: Convey allocation mode as argument (diff) | |
| download | kernel-e4ff7d6b8cee30a823347df8651444f8fa20b320.tar.gz kernel-e4ff7d6b8cee30a823347df8651444f8fa20b320.zip | |
net: ipw2x00,iwlegacy,iwlwifi: Remove in_interrupt() from debug macros
The usage of in_interrupt() in non-core code is phased out.
The debugging macros in these drivers use in_interrupt() to print 'I' or
'U' depending on the return value of in_interrupt(). While 'U' is confusing
at best and 'I' is not really describing the actual context (hard interupt,
soft interrupt, bottom half disabled section) these debug macros originate
from the pre ftrace kernel era and their value today is questionable. They
probably should be removed completely.
The macros weere added initially for ipw2100 and then spreaded when the
driver was forked.
Remove the in_interrupt() usage at least..
Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Acked-by: Kalle Valo <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/net/wireless/intel/iwlegacy/common.h')
| -rw-r--r-- | drivers/net/wireless/intel/iwlegacy/common.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/wireless/intel/iwlegacy/common.h b/drivers/net/wireless/intel/iwlegacy/common.h index bc9cd7e5ccb8..ea1b1bb7ddcb 100644 --- a/drivers/net/wireless/intel/iwlegacy/common.h +++ b/drivers/net/wireless/intel/iwlegacy/common.h @@ -2925,8 +2925,8 @@ do { \ #define IL_DBG(level, fmt, args...) \ do { \ if (il_get_debug_level(il) & level) \ - dev_err(&il->hw->wiphy->dev, "%c %s " fmt, \ - in_interrupt() ? 'I' : 'U', __func__ , ##args); \ + dev_err(&il->hw->wiphy->dev, "%s " fmt, __func__, \ + ##args); \ } while (0) #define il_print_hex_dump(il, level, p, len) \ |