diff options
| author | Michael Chan <[email protected]> | 2020-08-26 05:08:36 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2020-08-26 14:19:03 +0000 |
| commit | b148bb238c02f0c7797efed026e9bba5892d2172 (patch) | |
| tree | c065ceea1f1f0821ec18063eb708b736e7e8480e /drivers/net/wan/lapbether.c | |
| parent | bnxt_en: Fix PCI AER error recovery flow (diff) | |
| download | kernel-b148bb238c02f0c7797efed026e9bba5892d2172.tar.gz kernel-b148bb238c02f0c7797efed026e9bba5892d2172.zip | |
bnxt_en: Fix possible crash in bnxt_fw_reset_task().
bnxt_fw_reset_task() is run from a delayed workqueue. The current
code is not cancelling the workqueue in the driver's .remove()
method and it can potentially crash if the device is removed with
the workqueue still pending.
The fix is to clear the BNXT_STATE_IN_FW_RESET flag and then cancel
the delayed workqueue in bnxt_remove_one(). bnxt_queue_fw_reset_work()
also needs to check that this flag is set before scheduling. This
will guarantee that no rescheduling will be done after it is cancelled.
Fixes: 230d1f0de754 ("bnxt_en: Handle firmware reset.")
Reviewed-by: Vasundhara Volam <[email protected]>
Signed-off-by: Michael Chan <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/net/wan/lapbether.c')
0 files changed, 0 insertions, 0 deletions