diff options
| author | Julian Sun <[email protected]> | 2025-08-12 15:42:57 +0000 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2025-08-13 11:33:48 +0000 |
| commit | 8f5845e0743bf3512b71b3cb8afe06c192d6acc4 (patch) | |
| tree | ec5ada88b5f824c5b1d87286405eb817bbbf177f /drivers/net/wan/lapbether.c | |
| parent | Docs: admin-guide: Correct spelling mistake (diff) | |
| download | kernel-8f5845e0743bf3512b71b3cb8afe06c192d6acc4.tar.gz kernel-8f5845e0743bf3512b71b3cb8afe06c192d6acc4.zip | |
block: restore default wbt enablement
The commit 245618f8e45f ("block: protect wbt_lat_usec using
q->elevator_lock") protected wbt_enable_default() with
q->elevator_lock; however, it also placed wbt_enable_default()
before blk_queue_flag_set(QUEUE_FLAG_REGISTERED, q);, resulting
in wbt failing to be enabled.
Moreover, the protection of wbt_enable_default() by q->elevator_lock
was removed in commit 78c271344b6f ("block: move wbt_enable_default()
out of queue freezing from sched ->exit()"), so we can directly fix
this issue by placing wbt_enable_default() after
blk_queue_flag_set(QUEUE_FLAG_REGISTERED, q);.
Additionally, this issue also causes the inability to read the
wbt_lat_usec file, and the scenario is as follows:
root@q:/sys/block/sda/queue# cat wbt_lat_usec
cat: wbt_lat_usec: Invalid argument
root@q:/data00/sjc/linux# ls /sys/kernel/debug/block/sda/rqos
cannot access '/sys/kernel/debug/block/sda/rqos': No such file or directory
root@q:/data00/sjc/linux# find /sys -name wbt
/sys/kernel/debug/tracing/events/wbt
After testing with this patch, wbt can be enabled normally.
Signed-off-by: Julian Sun <[email protected]>
Cc: [email protected]
Fixes: 245618f8e45f ("block: protect wbt_lat_usec using q->elevator_lock")
Reviewed-by: Nilay Shroff <[email protected]>
Reviewed-by: Yu Kuai <[email protected]>
Reviewed-by: Ming Lei <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'drivers/net/wan/lapbether.c')
0 files changed, 0 insertions, 0 deletions
