diff options
| author | Krzysztof Hałasa <[email protected]> | 2025-04-08 11:59:41 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2025-04-11 01:42:50 +0000 |
| commit | 4145f00227ee80f21ab274e9cd9c09758e9bcf3d (patch) | |
| tree | 92b40bc4ae2ff8aecfc1182c712ce5c48539d0e3 /drivers/net/usb/asix.h | |
| parent | Merge branch 'trace-add-tracepoint-for-tcp_sendmsg_locked' (diff) | |
| download | kernel-4145f00227ee80f21ab274e9cd9c09758e9bcf3d.tar.gz kernel-4145f00227ee80f21ab274e9cd9c09758e9bcf3d.zip | |
usbnet: asix AX88772: leave the carrier control to phylink
ASIX AX88772B based USB 10/100 Ethernet adapter doesn't come
up ("carrier off"), despite the built-in 100BASE-FX PHY positive link
indication. The internal PHY is configured (using EEPROM) in fixed
100 Mbps full duplex mode.
The primary problem appears to be using carrier_netif_{on,off}() while,
at the same time, delegating carrier management to phylink. Use only the
latter and remove "manual control" in the asix driver.
I don't have any other AX88772 board here, but the problem doesn't seem
specific to a particular board or settings - it's probably
timing-dependent.
Remove unused asix_adjust_link() as well.
Signed-off-by: Krzysztof Hałasa <[email protected]>
Tested-by: Oleksij Rempel <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'drivers/net/usb/asix.h')
| -rw-r--r-- | drivers/net/usb/asix.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/usb/asix.h b/drivers/net/usb/asix.h index 74162190bccc..8531b804021a 100644 --- a/drivers/net/usb/asix.h +++ b/drivers/net/usb/asix.h @@ -224,7 +224,6 @@ int asix_write_rx_ctl(struct usbnet *dev, u16 mode, int in_pm); u16 asix_read_medium_status(struct usbnet *dev, int in_pm); int asix_write_medium_mode(struct usbnet *dev, u16 mode, int in_pm); -void asix_adjust_link(struct net_device *netdev); int asix_write_gpio(struct usbnet *dev, u16 value, int sleep, int in_pm); |