diff options
| author | Andrew Lunn <[email protected]> | 2018-12-05 20:49:45 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2018-12-06 00:26:16 +0000 |
| commit | 9db299c736eea35ea97dbc9d80a58befc067bcd8 (patch) | |
| tree | f0d724457dd46954952c7db156d267beed5e1545 /drivers/net/phy/phy.c | |
| parent | net: mii: mii_lpa_mod_linkmode_lpa_t: Make use of linkmode_mod_bit helper (diff) | |
| download | kernel-9db299c736eea35ea97dbc9d80a58befc067bcd8.tar.gz kernel-9db299c736eea35ea97dbc9d80a58befc067bcd8.zip | |
net: phy: Fix ioctl handler when modifing MII_ADVERTISE
When the MII_ADVERTISE register is modified by the IOCTL handler,
phydev->advertising needs recalculating. Use the _mod_ variant of
mii_adv_to_linkmode_adv_t so that bits outside of the advertise
registers are not cleared.
Fixes: c0ec3c273677 ("net: phy: Convert u32 phydev->lp_advertising to linkmode")
Reported-by: Heiner Kallweit <[email protected]>
Signed-off-by: Andrew Lunn <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/net/phy/phy.c')
| -rw-r--r-- | drivers/net/phy/phy.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index e1a1e54baac2..e24708f1fc16 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -437,8 +437,8 @@ int phy_mii_ioctl(struct phy_device *phydev, struct ifreq *ifr, int cmd) } break; case MII_ADVERTISE: - mii_adv_to_linkmode_adv_t(phydev->advertising, - val); + mii_adv_mod_linkmode_adv_t(phydev->advertising, + val); change_autoneg = true; break; default: |