diff options
| author | Nikolay Aleksandrov <[email protected]> | 2013-09-19 13:02:35 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2013-09-19 18:15:53 +0000 |
| commit | d0fe8c888b1fd1a2f84b9962cabcb98a70988aec (patch) | |
| tree | 0d148e7dfea45c04842617aa32c9be50235d606a /drivers/net/netconsole.c | |
| parent | skge: fix broken driver (diff) | |
| download | kernel-d0fe8c888b1fd1a2f84b9962cabcb98a70988aec.tar.gz kernel-d0fe8c888b1fd1a2f84b9962cabcb98a70988aec.zip | |
netpoll: fix NULL pointer dereference in netpoll_cleanup
I've been hitting a NULL ptr deref while using netconsole because the
np->dev check and the pointer manipulation in netpoll_cleanup are done
without rtnl and the following sequence happens when having a netconsole
over a vlan and we remove the vlan while disabling the netconsole:
CPU 1 CPU2
removes vlan and calls the notifier
enters store_enabled(), calls
netdev_cleanup which checks np->dev
and then waits for rtnl
executes the netconsole netdev
release notifier making np->dev
== NULL and releases rtnl
continues to dereference a member of
np->dev which at this point is == NULL
Signed-off-by: Nikolay Aleksandrov <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/net/netconsole.c')
0 files changed, 0 insertions, 0 deletions