diff options
| author | Alexander Lobakin <[email protected]> | 2020-07-06 15:38:15 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2020-07-06 20:18:55 +0000 |
| commit | 365cd2cee0c9813ccabe3e5b12c1b3bf499f8c27 (patch) | |
| tree | 8b58c088bd391a2afa15fbdd090b363037a1f155 /drivers/net/ethernet/qlogic/qed/qed_debug.c | |
| parent | net: qed: cleanup global structs declarations (diff) | |
| download | kernel-365cd2cee0c9813ccabe3e5b12c1b3bf499f8c27.tar.gz kernel-365cd2cee0c9813ccabe3e5b12c1b3bf499f8c27.zip | |
net: qed: correct qed_hw_err_notify() prototype
Change the prototype of qed_hw_err_notify() with the following:
* constify "fmt" argument according to printk() declarations;
* anontate it with __cold attribute to move the function out of
the line;
* annotate it with __printf() attribute;
This eliminates W=1+ warning:
drivers/net/ethernet/qlogic/qed/qed_hw.c: In function
‘qed_hw_err_notify’:
drivers/net/ethernet/qlogic/qed/qed_hw.c:851:3: warning: function
‘qed_hw_err_notify’ might be a candidate for ‘gnu_printf’ format
attribute [-Wsuggest-attribute=format]
len = vsnprintf(buf, QED_HW_ERR_MAX_STR_SIZE, fmt, vl);
^~~
as well as saves some code size:
add/remove: 0/0 grow/shrink: 2/4 up/down: 40/-125 (-85)
Function old new delta
qed_dmae_execute_command 1680 1711 +31
qed_spq_post 1104 1113 +9
qed_int_sp_dpc 3554 3545 -9
qed_mcp_cmd_and_union 1896 1876 -20
qed_hw_err_notify 395 352 -43
qed_mcp_handle_events 2630 2577 -53
Total: Before=368645, After=368560, chg -0.02%
__printf() will also be helpful with catching bad format strings
and arguments.
Signed-off-by: Alexander Lobakin <[email protected]>
Signed-off-by: Igor Russkikh <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/net/ethernet/qlogic/qed/qed_debug.c')
0 files changed, 0 insertions, 0 deletions
