diff options
| author | Stefan Assmann <[email protected]> | 2020-08-20 11:53:12 +0000 |
|---|---|---|
| committer | Tony Nguyen <[email protected]> | 2020-09-09 22:06:24 +0000 |
| commit | b6f23d3817b965bcd6d72aab1f438ff6d16a0691 (patch) | |
| tree | 30a9b1ebb79c1750ca25e3e4534b7ecaf53191c6 /drivers/net/ethernet/intel/igc | |
| parent | i40e: fix return of uninitialized aq_ret in i40e_set_vsi_promisc (diff) | |
| download | kernel-b6f23d3817b965bcd6d72aab1f438ff6d16a0691.tar.gz kernel-b6f23d3817b965bcd6d72aab1f438ff6d16a0691.zip | |
i40e: always propagate error value in i40e_set_vsi_promisc()
The for loop in i40e_set_vsi_promisc() reports errors via dev_err() but
does not propagate the error up the call chain. Instead it continues the
loop and potentially overwrites the reported error value.
This results in the error being recorded in the log buffer, but the
caller might never know anything went the wrong way.
To avoid this situation i40e_set_vsi_promisc() needs to temporarily store
the error after reporting it. This is still not optimal as multiple
different errors may occur, so store the first error and hope that's
the main issue.
Fixes: 37d318d7805f (i40e: Remove scheduling while atomic possibility)
Reported-by: Michal Schmidt <[email protected]>
Signed-off-by: Stefan Assmann <[email protected]>
Tested-by: Aaron Brown <[email protected]>
Signed-off-by: Tony Nguyen <[email protected]>
Diffstat (limited to 'drivers/net/ethernet/intel/igc')
0 files changed, 0 insertions, 0 deletions